Add identity sign CLI command#2817
Open
vaizki wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a command to sign arbitrary data with the repeater / room server private key. The use is to authenticate repeater ownership on analysis platforms etc.
identity verify <message> <signature>was planned but scrapped due to the same limitationsmesh::Utils::fromHex()returns 0 for errors like non-hexchars which is a bit ambiguous so a new helperparseHexBytes()was added, this could be inlined of courseExample: I want to view my node's detailed statistics so the platorm asks me to sign a random string (in this case "MeshCore"):
After pasting the resulting signature to the platform it can be certain that I have access to the node and its private key, allowing me to link the repeater to my account.
Note: This function already exists in the KISS firmware as the SetHardware Extensions (0x06) -> SignData (0x04) TNC command and includes the verify command as well. So this brings the same feature to the repeater CLI.