Skip to content

[WTF-2693]: Re-enable test command in command tests #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weirdwater merged 2 commits into from
Jun 19, 2026
+7 −16
Merged

[WTF-2693]: Re-enable test command in command tests #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b980480
Re-enable test command in command tests
weirdwater Jun 17, 2026
9700a0e
Fix formatting
weirdwater Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions packages/command-tests/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ async function main() {
await testLint();

// Temporarily disabled due to bizarre typing issues in the CI that cannot be reproduced in any local environment
// logger(`Testing unit tests....`);
// await testTest();
logger(`Testing unit tests....`);
await testTest();

if (LIMIT_TESTS) {
logger(`Quick tested!`);
Expand All @@ -131,10 +131,6 @@ async function main() {
logger(`Testing 'build' command...`);
await testBuild();

// Temporarily disabled due to bizarre typing issues in the CI that cannot be reproduced in any local environment
// logger(`Testing 'test:unit' command...`);
// await testTestUnit();

logger(`Testing 'release' command...`);
await testRelease();

Expand Down Expand Up @@ -211,7 +207,6 @@ async function main() {
await execAsync("npm run lint", workDir, logger);
}

// eslint-disable-next-line no-unused-vars
async function testTest() {
if (platform === "native") {
await execFailedAsync("npm test -- --forceExit", workDir);
Expand All @@ -235,14 +230,6 @@ async function main() {
}
}

// eslint-disable-next-line no-unused-vars
async function testTestUnit() {
await execAsync("npm run test:unit -- --forceExit", workDir, logger);
if (!existsSync(join(workDir, `/dist/coverage/clover.xml`))) {
throw new Error("Expected coverage file to be generated, but it wasn't.");
}
}

async function testRelease() {
rm("-rf", join(workDir, "dist"));
await execAsync("npm run release", workDir, logger);
Expand Down
4 changes: 4 additions & 0 deletions packages/generator-widget/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Changed

- We cleaned up a template with unused imports.

## [11.11.0] - 2026-06-04

### Changed
Expand Down
2 changes: 1 addition & 1 deletion ...rs/app/templates/pluggable/web/fullTemplateTs/src/components/__tests__/Alert.spec.tsx.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { render, screen } from "@testing-library/react";
import { render } from "@testing-library/react";
import "@testing-library/jest-dom";

import { Alert } from "../Alert";
Expand Down
Loading