[WTF-2641]: Format generated types#182
Open
weirdwater wants to merge 5 commits into
Open
Conversation
weirdwater
force-pushed
the
wtf-2641-release-style-error
branch
from
979c24d to
4bf91e7
Compare
alihcsumer
reviewed
Jun 17, 2026
| const fakeFilename = join(cwd(), "./src/widget.ts"); | ||
| // If the widget does not have a prettier config, fall back to packaged base config | ||
| const prettierConfig = | ||
| (await resolveConfig(fakeFilename)) ?? JSON.parse(await readFile(prettierConfigBasePath, "utf-8")); |
Contributor
There was a problem hiding this comment.
Can resolveConfig here end up resolving a different prettier config than the one the release check uses on the generated code?
Collaborator
Author
There was a problem hiding this comment.
Reviewing the prettier command in the mx-scripts.js, it only resolves to the prettier.config.js file in the widget and does not pick up other prettier configuration options.
Collaborator
Author
There was a problem hiding this comment.
I updated the mx-scripts and the typings generator to use the same prettier configuration and rebased.
weirdwater
force-pushed
the
wtf-2641-release-style-error
branch
from
d38841f to
57914c7
Compare
weirdwater
force-pushed
the
wtf-2641-release-style-error
branch
from
57914c7 to
0e434aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
Avoid linting errors when running the
releasecommand. As a side-effect, the generated types will now respect the widget's prettier config.Relevant changes
Before writing the generated types to the definition file, the type generator now runs prettier to format the source.
What should be covered while testing?
Widget with many client types
Prerequisites
Steps
npx @mendix/pluggable-widgets-tools buildnpx @mendix/pluggable-widgets-tools lintResult
Widget with custom prettier rules
Prerequisites
Steps
prettier.config.js, add the following settings:npx @mendix/pluggable-widgets-tools buildnpx @mendix/pluggable-widgets-tools lintResult