[WC-3460]: FileUploader pre-release QA & decision review#2269
Open
yordan-st wants to merge 4 commits into
Open
[WC-3460]: FileUploader pre-release QA & decision review#2269yordan-st wants to merge 4 commits into
yordan-st wants to merge 4 commits into
Conversation
…rning on invalid-format drop
75a2ada to
3f56f19
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…not clearing on dismiss
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Pre-release QA and decision review for file-uploader-web covering changes introduced by WC-3361 (upload queue, concurrent upload limit, total file limit feedback, retry for over-limit files, list ordering) and WC-3363 (dismiss for invalid-format rejections, yellow warning lifecycle).
Two bugs found and fixed:
sortedFileswas only pushingvalidationErrorentries to the end of the list;rejected(over-limit) files were sorting alongside successful uploads. Fixed to push bothvalidationErrorandrejectedbelow all other entries.hasValidationErrorscomputed intoFileUploaderRootwarningMessage logic — banner appears whenvalidationErrorfiles are present and clears when all are dismissed.What should be covered while testing?
File limit feedback
maxFilesPerUpload = 3. Drop 3 files → dropzone greys out + "Maximum file count of 3 reached." message appearsmaxFilesPerUpload = 0or leave empty → dropzone never disables, no message ever shownUpload queue
maxFilesPerBatch = 2. Drop 5 files → exactly 2 show "Uploading…", remaining 3 show "Waiting…" with no progress barmaxFilesPerBatchempty → all dropped files start uploading simultaneouslyRetry for over-limit rejections
maxFilesPerUpload = 2. Drop 4 files → 2 upload, 2 appear as rejected with retry button greyed outDismiss for invalid-format rejections
List ordering
Regression checks
readOnlyMode = true→ dropzone is not rendered, no errorsuploadModeto images → queue, limit, and dismiss behavior works identically to files mode