Add test to validate document order preservation for positional includes#3096
Add test to validate document order preservation for positional includes#3096christiangoerdes wants to merge 5 commits into
Conversation
|
/ok-to-test |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe change documents in-place YAML includes, adds parser coverage for preserved document order, and introduces composed and positional-include tutorials with shell and Windows launchers plus HTTP integration tests. ChangesInclude Tutorials and Positional Routing
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant Membrane
participant IncludedAPI
participant FallbackAPI
Client->>Membrane: Request /shop/orders, /shop, or /unknown
Membrane->>IncludedAPI: Apply positional route matching
IncludedAPI-->>Membrane: Return configured 200 response
Membrane->>FallbackAPI: Handle unmatched request
FallbackAPI-->>Membrane: Return 404 response
Membrane-->>Client: Send HTTP response
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request needs "/ok-to-test" from an authorized committer. |
Summary by CodeRabbit
New Features
include:expansion now preserves document order, so routing priority follows eachinclude’s location.Documentation
includerouting priority and in-place expansion behavior (with updated examples).Tests
Chores