fix(StopController): remove AlertsByTimeframe#3336
Merged
Conversation
jlucytan
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🐞 Stop page | KeyError: key :alerts not found
Implementation
Two different Sentry errors indicate the
AlertsByTimeframeplug was erroring on stop pages because it neededconn.assigns.alerts.However... the stop pages don't make use of
AlertsByTimeframe(which segmented alerts into current and upcoming) anymore. So it turns out we could get rid of this call entirely.The final place that plug is still used in is
BusStopChangesController, which handles/bus-stop-changes.How to test
No more error on stop pages!