Feature upgrade: auto-clean catalog & bug fixes - #23
Merged
Conversation
DROP TABLE ... CASCADE only removes the table and its Citus shards; it has no dependency link to this extension's own bookkeeping in pg_dist_spatiotemporal_tables/pg_dist_spatiotemporal_tiles, so those rows were silently orphaned. Add an event trigger on sql_drop that removes the matching catalog rows automatically, guarding against the case where the extension itself (and its catalog tables) is being dropped in the same command.
The tile-size binary search only exits on an exact match against the per-tile target count. When the target rounds down to 0 (few rows relative to the requested tile count) or the split point plateaus at floating-point precision before matching exactly, the loop never converges and hangs indefinitely. Cap it at 100 rounds and settle for the current best split point instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.