client-api: fix sync v5 set_presence query parameter#7
Merged
Merged
Conversation
x86pup
merged commit 2f21f03
into
matrix-construct:tuwunel-changes
7 of 21 checks passed
Author
|
Thanks @x86pup! I was wondering if I should open a PR in tuwunel to update the ruma version, or what the appropriate procedure should be to get this into tuwunel? Thanks 🙂 |
Member
|
A PR to bump the ruma rev would be acceptable. |
Member
|
@lhjt Bumping ruma is actually a bit more involved as we need to bump matrix-construct/synapse-admin-api ruma too. I'm currently doing some related work with ruma, so I will handle this myself. Thank you for this fix though! ❤️ |
Author
|
@x86pup yep I figured that out and had already raised the PR here: matrix-construct/synapse-admin-api#1 If you would like me to close it just lmk 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure
set_presenceparameter is read on v5 sync calls.Context
It is possible to pass a
set_presenceparameter when syncing. This is especially important as the heuristics used for push notification suppression in tuwunel rely on clients reporting accurate device presence.Tuwunel has currently been reading all v5 /sync calls from devices as having an Online presence, even if they have the
set_presenceparameter set.This PR resolves the issue.