fix: normalize BrightScript hex literals in enum/const values#15
Merged
Conversation
enumMember.getValue() and const literal tokens emit raw BrightScript source text (e.g. &hFF0000FF), which isn't valid JS and crashes jsdoc's parser for the whole file. Convert &hHEX to 0xHEX before emitting. Fixes #14
Exercises the &h hex literal normalization fix via npm run testdocs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processEnumandprocessConstemit raw BrightScript literal source text (e.g.&hFF0000FF) verbatim into the generated pseudo-JS&h...isn't valid JS, so jsdoc's parser throws and doc generation fails for the whole file&hHEXtokens to0xHEXbefore emitting, in both processEnum and processConstTest plan
npm run buildnpm run lintnpm test(added coverage for hex literals in enum members and const values)Fixes #14