feat: support async shorthand methods - #588
Conversation
🦋 Changeset detectedLatest commit: fe9b102 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (14)
📒 Files selected for processing (11)
Comment |
Thread the parser's new `async` flag through the AST and the script
extractor, so the body of `<button async onClick() { await save() }>`
type-checks as an async function.
Requires htmljs-parser 5.14.0.
64674db to
d78d268
Compare
@marko/compiler 5.42 carries the async shorthand method support. The snapshot churn is its new deprecation diagnostic for the `<effect>` tag, which seven fixtures still use.
Threads htmljs-parser's new
asyncflag through the AST and the script extractor, so the body of<button async onClick() { await save() }>type-checks as an async function. Also adds a TextMate rule for the keyword, and keeps a whitespace preceded>=inside an attribute value rather than ending the tag.Requires htmljs-parser 5.14.