feat: support async shorthand methods - #236
Conversation
🦋 Changeset detectedLatest commit: fdc63d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 30 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (7)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 34 34
Lines 4466 4558 +92
Branches 853 874 +21
=======================================
+ Hits 4464 4556 +92
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Parse an `async` keyword before a shorthand method, eg
`<button async onClick() {}>`, and pass its range through `onAttrMethod`.
Whether `async` modifies a method or is an attribute of its own is not known
until the args are closed, so the name events are deferred until then. An
`async` not followed by a shorthand method stays an ordinary attribute,
keeping `<script async src=x>` and the `async`-named method
`<foo async (event) {}>` intact.
5c03fc5 to
fdc63d2
Compare
1 participant
Parses an
asynckeyword before a shorthand method, eg<button async onClick() { await save() }>, and the default attribute form<foo async (event) { ... }>.onAttrMethodreports these withasync: trueand a range starting at the keyword.Whether
asyncmodifies a method or is an attribute in its own right is not known until the args close and a{follows, so the name events are deferred until then. Anasyncnot followed by a shorthand method stays an ordinary attribute, which keeps<script async src=x>working. As a consequence a shorthand method can no longer be namedasync.