feat: mission binding verification and AAuth-Mission coverage enforcement - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two mission-shaped additions that belong in the library because both the person server and mission-aware resources need them (lifecycle/state stays in the person server):
MissionBinding—s256(bytes)matching the PS reference encoding (unpadded base64url SHA-256 of the canonical mission JSON),matchesDocument(mission, bytes), andmatchesClaim(mission, tokenMissionClaim).RequestVerifier— theResultrecord now carries the parsedAAuth-Missionheader (result.mission()), and a request bearingAAuth-Missionwithoutaauth-missionamong the signature-covered components is rejected (aauth-mission header not covered by signature). Stricter than the Python reference — an uncovered header could be swapped after signing; documented under deviations.Tests: s256 reference vector, document/claim matching, mission surfaced when covered, injected-after-signing header rejected, missionless requests unchanged. 207 tests green, all gates met.
🤖 Generated with Claude Code