build: @NullMarked the aauth module (NullAway-clean) - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last documented hygiene deferral: the
aauthmodule is now fully@NullMarked(JSpecify), matchingaauth-signing. NullAway runs clean on its main sources.@NullMarkedpackage-info added to all 8aauthpackages.@Nullableon optional record components, builder fields, exception constructor params/accessors, and nullable helper returns (case-insensitive header lookups,getKeyByKid, cacheget, parse helpers) — mirroring the patterns already inaauth-signing.AuthTokens.Spec.Builder.build()validates required fields before constructing (validate-then-construct, likeSignRequest);TokenExchange/Pollerbuilders normalize defaulthttpClient/sleeper;DeferredResponses.parsePendingResponserewrites the status normalization to an equivalent form NullAway can prove.No runtime behavior change; no wire change — pure internal null-safety, so no downstream sync needed (consumers stay on 0.2.3). 214 tests green, coverage + Spotless gates met.
🤖 Generated with Claude Code