Skip to content

Fix lower amplitude bound: use nearest-edge distance, not nearest vertex #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomkoenecke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix lower amplitude bound: use nearest-edge distance, not nearest vertex #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion fourier/transform/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,21 @@ def in_complex_hull(chull,point=(0,0)): # default check the origin of the comple
if in_complex_hull(convhull):
boundC = Interval(0,abs(convhull[ch_max]))
else:
boundC = Interval(abs(convhull[ch_min]),abs(convhull[ch_max]))
boundC = Interval(dist_origin_to_hull(convhull),abs(convhull[ch_max]))
return boundI, boundC, (convhull[ch_min], convhull[ch_max])

def dist_origin_to_hull(chull): # min |z| over the hull = distance to the nearest edge, not the nearest vertex
pts = [(c.real, c.imag) for c in chull]
dmin = float('inf')
for i in range(len(pts)):
ax,ay = pts[i]; bx,by = pts[(i+1) % len(pts)]
dx,dy = bx-ax, by-ay
denom = dx*dx + dy*dy
t = 0.0 if denom == 0 else min(1.0, max(0.0, -(ax*dx + ay*dy) / denom))
px,py = ax + t*dx, ay + t*dy
dmin = min(dmin, (px*px + py*py)**0.5)
return dmin

def compute_amplitude_bounds(intervalsignal):
N = len(intervalsignal)
BOUNDS_I = []
Expand Down