Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
410f558 to
d323e3a
Compare
fddd6f0 to
c01202f
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThe workspace adds the feature-gated ChangesEngine primitives and calculator interface
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant OS
participant ShutdownManager
participant ShutdownHandle
participant Service
OS->>ShutdownManager: Send shutdown signal
ShutdownManager->>ShutdownHandle: Cancel service tier
ShutdownHandle->>Service: Notify cancellation
Service->>ShutdownManager: Report termination reason
ShutdownManager->>ShutdownManager: Drain tier with timeout
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
02c3fc8 to
5400e0f
Compare
9d93c24 to
5ea2822
Compare
88dd3ba to
88afbef
Compare
|
@CodeRabbit review |
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@nucleus/src/heed.rs`:
- Around line 27-45: Remove the lifetime-extending transmute calls from
DatabaseIndex::write_txn and DatabaseIndex::read_txn. Bind newly opened
transactions to the borrow of self.env(), or adopt an owner that keeps the Env
alive, while preserving supplied transactions and caller-owned storage without
requiring unsafe lifetime assumptions.
In `@nucleus/src/testkit.rs`:
- Around line 60-66: Update the block function’s hash construction so all bits
of Slot contribute to a deterministic hash, avoiding collisions between slots
that differ beyond the lowest byte. Preserve the existing block fields and
ensure distinct Slot values produce distinct hashes within the supported Slot
range.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ac2e5c95-96a6-453e-a119-976b7e354a00
📒 Files selected for processing (18)
Cargo.tomlnucleus/Cargo.tomlnucleus/README.mdnucleus/src/config.rsnucleus/src/heed.rsnucleus/src/ledger.rsnucleus/src/lib.rsnucleus/src/metrics.rsnucleus/src/notifier.rsnucleus/src/runtime.rsnucleus/src/shutdown.rsnucleus/src/testkit.rsnucleus/src/tls.rsprograms/v42-calculator-interface/Cargo.tomlprograms/v42-calculator-interface/README.mdprograms/v42-calculator-interface/src/builder.rsprograms/v42-calculator-interface/src/lib.rsprograms/v42-calculator-interface/src/opcodes.rs

What changed
Added the
nucleuscrate with feature-gated primitives shared across the engine stack.Why
Ledger, runtime, storage, and orchestration crates need common types and lifecycle
coordination without assigning storage or execution policy to the shared dependency.
Closes #28.
Impact
metrics helpers, thread-local runtime state, and test support.
narrow crate features.
ShutdownManager, service handles, ordered cancellation tiers, andbounded termination reporting.
Reviewer notes
Shutdown cancels the replication client, pacemaker, sequencer, and remaining
services in order. Each tier receives its own bounded window to report completion
before shutdown advances.
Follow-up
Ledger, keeper, processor, engine, and replication services consume these
feature-gated primitives upstack.