Fix double-close of _serverFd in SocketServer teardown#585
Open
zardus wants to merge 1 commit into
Open
Conversation
Collaborator
|
Do you think you can merge master in your branch, I think I fixed the build issue. with uwp, then we'll reckick the PR checks. |
SocketServer::stop() closed _serverFd but never cleared it, and stop()
runs again from both ~WebSocketServer() and ~SocketServer(), so every
teardown closed the same fd number two or three times. If another
thread opens a descriptor between those closes, the kernel reuses the
number and the stale close destroys it — observed as intermittent
process aborts ("Unexpected error 9 on netlink descriptor", glibc's
getaddrinfo netlink probe) when a DNS lookup raced a server teardown.
Close the fd once and set it to -1, in stop() and in the listen()
error paths.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
zardus
force-pushed
the
fix-serverfd-double-close
branch
from
6fe6330 to
26affe6
Compare
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm using IXWebSocket in https://github.com/openglad/openglad, and ran into an issue when using this in a multithreaded setting.
It seems that
SocketServer::stop()closes_serverFdbut never clears it, and stop() runs again from both~WebSocketServer()and~SocketServer(), so every teardown closes the same fd number two or three times. If another thread opens a descriptor between those closes, the kernel reuses the number and the stale close destroys it. I was hitting intermittent process aborts ("Unexpected error 9 on netlink descriptor", glibc's getaddrinfo netlink probe) whenever a DNS lookup in another thread raced a server teardown.This PR sets
_serverFdto -1 after closing it (including in error paths), like what seems to happen to_sockfdcurrently elsewhere in the code. This seems to have fixed it for me.