Start including ECH data in RouteSelector results#9557
Merged
Conversation
yschimke
reviewed
Jul 17, 2026
yschimke
reviewed
Jul 17, 2026
yschimke
reviewed
Jul 17, 2026
| records | ||
| .filterIsInstance<Dns.Record.IpAddress>() | ||
| .map { record -> | ||
| val serviceMetadata = hostnameToServiceMetadata[record.hostname] |
Collaborator
There was a problem hiding this comment.
Is this correct? if the DNS record is pointing to multiple backend DNS Servers?
;; Multiple HTTPS records for the same domain
example.com. 3600 IN HTTPS 1 server1.anking.com. alpn="h2,h3"
example.com. 3600 IN HTTPS 2 server2.anking.com. alpn="h2,h3"
Is that possible?
Collaborator
Author
There was a problem hiding this comment.
You got it. And now that I’m staring at it, I also need to handle "" there. Fixed!
Collaborator
Author
There was a problem hiding this comment.
(I’m hoping to follow up with code in DnsOverHttps that honors ServiceMode and AliasMode, by making recursive calls. It’s a bit like CNAME handling.)
yschimke
approved these changes
Jul 17, 2026
yschimke
left a comment
yschimke
left a comment
Collaborator
There was a problem hiding this comment.
1 question about hostname filtering
This changes RouteSelector to use our new async API, when it is available.
swankjesse
force-pushed
the
jwilson.0717.ech_selected
branch
from
July 17, 2026 20:30
3349935 to
77babd6
Compare
CompletableFuture isn't available until Android API 24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes RouteSelector to use our new async API, when it is implemented.