Skip to content

Add constraints in Dockerfile - #229

Merged
klemen1999 merged 2 commits into
mainfrom
fix/docker_images
Aug 11, 2026
Merged

Add constraints in Dockerfile#229
klemen1999 merged 2 commits into
mainfrom
fix/docker_images

Conversation

@klemen1999

@klemen1999 klemen1999 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Purpose

  • constraints are now included into the docker images

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

AI Usage

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]

Submitted code was reviewed by a human: YES/NO

The author is taking the responsibility for the contribution: YES/NO

Summary by CodeRabbit

  • Bug Fixes
    • Improved dependency installation reliability during container builds.
    • Preserved compatibility with bundled YOLOv6 and YOLOv7 components by constraining the setuptools version.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@klemen1999, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a178ebb0-af45-4fbd-ba4e-61b55a5f569d

📥 Commits

Reviewing files that changed from the base of the PR and between 6641bcc and fafcde3.

📒 Files selected for processing (3)
  • Dockerfile
  • constraints.txt
  • requirements.txt
📝 Walkthrough

Walkthrough

The Docker image now applies constraints.txt to regular and isolated pip builds. requirements.txt constrains setuptools below version 82 for vendored YOLOv6 and YOLOv7 imports.

Changes

Dependency constraints

Layer / File(s) Summary
Constrained dependency installation
Dockerfile, requirements.txt
The Docker build copies constraints.txt and sets PIP_CONSTRAINT and PIP_BUILD_CONSTRAINT. requirements.txt adds setuptools<82 for vendored YOLOv6 and YOLOv7 imports.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • luxonis/tools#227: Both changes constrain setuptools below version 82 and apply PIP_BUILD_CONSTRAINT to isolated pip builds.

Suggested reviewers: rolandocortez

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding dependency constraints to the Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docker_images

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Dockerfile`:
- Around line 15-18: Update the Dockerfile dependency installation step before
the existing pip install command to explicitly install or upgrade pip to version
26.2 or newer, then retain the PIP_CONSTRAINT and PIP_BUILD_CONSTRAINT settings
for installing the project. Add or update CI coverage to verify the container
uses the required pip version.

In `@requirements.txt`:
- Line 1: Update the setuptools requirement in requirements.txt and the
corresponding constraint in constraints.txt to use the bounded range
setuptools>=78.1.1,<82, preserving pkg_resources compatibility while excluding
vulnerable older releases.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 851523b6-d47b-4bb7-a9f8-46ce796be6cc

📥 Commits

Reviewing files that changed from the base of the PR and between 8839855 and 6641bcc.

📒 Files selected for processing (2)
  • Dockerfile
  • requirements.txt

Comment thread Dockerfile Outdated
Comment thread requirements.txt Outdated
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2028 1130 56% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: fafcde3 by action🐍

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

Test Results

  6 files    6 suites   15m 8s ⏱️
 32 tests  32 ✅ 0 💤 0 ❌
192 runs  192 ✅ 0 💤 0 ❌

Results for commit fafcde3.

♻️ This comment has been updated with latest results.

@klemen1999
klemen1999 merged commit a9e054f into main Aug 11, 2026
28 checks passed
@klemen1999
klemen1999 deleted the fix/docker_images branch August 11, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants