fix(ga): retry metadata-only responses#690
Open
Fwind43 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat responses containing only
<thinking>/<summary>metadata as incomplete instead of accepting them as final user-visible output.Why
A real run ended after the model returned only:
There was no tool call and no user-visible answer.
do_no_toolaccepted it as a normal final result, leaving GA Admin with an empty terminal turn rendered as “正在等待该轮输出…”.The metadata-only path now reuses the existing incomplete-response retry and exit policy.
Testing
response.thinking-only, and mixed metadata responsespy_compilegit diff --checkReview principles
ga.py