Skip to content

⚡ Optimize repeated regex compilation in onclick handler audit #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lsb11 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize repeated regex compilation in onclick handler audit #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions seo-audit.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,20 @@ for (const f of htmlFiles) {


// dead onclick handlers: onclick="fn()" must resolve to a global in the page
for (const fn of new Set([...html.matchAll(/onclick="(\w+)\(/g)].map(m=>m[1]))) {
if (!(new RegExp('function\\s+'+fn+'\\b').test(html) || new RegExp('window\\.'+fn+'\\s*=').test(html)))
err(`${page} — onclick handler ${fn}() has NO global definition (script bundled as module? use is:inline)`);
const fnsArr = [...new Set([...html.matchAll(/onclick="(\w+)\(/g)].map(m=>m[1]))];
if (fnsArr.length > 0) {
const fnsPattern = fnsArr.join('|');
const defRegex = new RegExp(`(?:function\\s+(${fnsPattern})\\b)|(?:window\\.(${fnsPattern})\\s*=)`, 'g');
const existingFns = new Set();
for (const match of html.matchAll(defRegex)) {
if (match[1]) existingFns.add(match[1]);
if (match[2]) existingFns.add(match[2]);
if (existingFns.size === fnsArr.length) break;
}
for (const fn of fnsArr) {
if (!existingFns.has(fn))
err(`${page} — onclick handler ${fn}() has NO global definition (script bundled as module? use is:inline)`);
}
}

// JSON-LD validity
Expand Down