fix: handle root in join and directory_name - #15
Open
JackoCoolio wants to merge 1 commit into
Open
Conversation
Previously, `join`ing an empty string with an absolute path (and
vice-versa) would result in a relative path. Now, it returns the
absolute path.
As a side-effect, `directory_name("/")` returns `"/"`, where it used to
return an empty string. This matches the behavior of C's `dirname("/")`
and Erlang's `filename:dirname("/")`.
lpil
reviewed
Aug 3, 2026
lpil
left a comment
lpil
left a comment
Owner
There was a problem hiding this comment.
Lovely. Could you update the changelog please 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9.
Previously,
joining an empty string with an absolute path (and vice-versa) would result in a relative path. Now, it returns the absolute path.As a side-effect,
directory_name("/")returns"/", where it used to return an empty string. This matches the behavior of C'sdirname("/")and Erlang'sfilename:dirname("/").