Add forms in body_format and PUT in VALID_VERBS#28
Open
MikeKemmerer wants to merge 3 commits into
Open
Conversation
Adding support for a body_format value of 'form' to support content-type: application/x-www-form-urlencoded until the body_format config is removed in favor of content_type.
Author
|
ELASTIC_STACK_VERSION=8.0.0-SNAPSHOT test environment appears to be broken |
Part of a previous request: add PUT to the VALID_VERBS list.
MikeKemmerer
commented
Jan 26, 2021
MikeKemmerer
left a comment
MikeKemmerer
left a comment
Author
There was a problem hiding this comment.
Added PUT to the list of VALID_VERBS as well
Updated documentation to reflect addition of 'PUT' verb and 'form' body_format
MikeKemmerer
changed the title
MikeKemmerer
changed the title
|
Thanks Mike, this is looking good. Any chance on writing a naive test for the change? |
|
PUT request shipped at #34, there's more in this PR however it seems stale |
Author
|
Unfortunately, I'm no good at writing tests. FWIW, I've got my fork running safely in an enterprise environment with no issues :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for a body_format value of 'form' to support content-type: application/x-www-form-urlencoded until the body_format config is removed in favor of content_type.