Sessionpaths - #208
Open
rountree wants to merge 11 commits into
Open
Conversation
Replaces --commpath with --commpaths. Takes a colon-separated list of commpaths. The choice of which of those to use is made per-server. The first workable path is selected. The paths may differ from server to server: unlike --cachepaths, there is no consensus process.
See ci-artifacts branch/PR for description. The workflows need be added here as the files are required to be both in the default branch as well as the branch using the workflows.
For the slurm-plugin case, fix copy/paste error by updating container names to those found in docker-compose.yml. (h/t Nick) Co-authored-by: Nicholas Chaimov <nchaimov@gmail.com>
Typo fix. h/t Nick. Co-authored-by: Nicholas Chaimov <nchaimov@gmail.com>
h/t Nick. Co-authored-by: Nicholas Chaimov <nchaimov@gmail.com>
src/client/client_comlib/client_api.c message.data (via buffer) is allocated 2*(MAX_PATH_LEN+1) bytes on the stack. message.data now truncated to 2*(MAX_PATH_LEN+1)-1 after the message is populated. src/fe/startup/parse_launcher.cc Both getFirstValidPath() and getApplicationArgsFE() were ignoring return values. Both now immediately return -1 on error, and the enclosing funciton signature has been converted from void to int.
Handles configure-, build-, and runtime options.
The session path had originally been derived from the local storage path. With the commpath/cachepath split, it was briefly a hardcoded path, and we discussed deriving sessionpath from commpath. However, that requires users to remember to specify the same commpaths for every session job (as well as the session intialization), and things will break if an unmounted path at the head of the commpath list becomes available during the session. The simplest solution is to leverage the existing spindle_mkdir() and cleanup code with the persistent session initialization job creating the directory and cleaning it up on exit. spindle_mkdir() was built twice, with and without directory tracking, and the front end needed to link to both (the logger requires tracking be disabled). The solution was to get rid of the comile time flag and parameterize tracking in the function signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass for adding explicit parameters for session paths.