CS-1992: Skip claim race fix - #123
Open
alexlivekit wants to merge 1 commit into
Open
Conversation
erikhortsch
added a commit
that referenced
this pull request
Aug 21, 2026
CS-1992: a handler that errors on receipt publishes its response right behind the announcement, on a different channel, and nothing orders their delivery. When the response won the race, selection stashed it as a fallback and the announcement then sent the caller off to wait on a channel already drained, turning an instant error into a request timeout. The stash exists for broadcast, where an early error is one server rejecting a request it could not read and another may yet bid. On a queue rpc the responder is the only server that received the request, so nothing else can ever arrive: return the response the moment it appears. This also stops a queue caller from waiting out the selection timeout to surface a malformed-request rejection, the case with no announcement at all. Reported in #123, which surfaced the stashed error once the announcement arrived; resolving it at the response site keeps selection from consuming the answer in the first place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.