display: 3-way "Automatic screen rotation" control#13826
Open
ggiesen wants to merge 1 commit into
Open
Conversation
Replace the Display -> Settings rotation toggle with a combobox (Disabled / Enabled / Tablet mode only), as suggested in linuxmint#10697, over the existing orientation-lock plus the new disable-rotation-in-laptop-mode key. The tablet-mode gating itself lives in Muffin (linuxmint/muffin#832) and the new key in cinnamon-settings-daemon (linuxmint#463). Supersedes linuxmint#10708. Re: linuxmint#10697.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Disable automatic screen rotation toggle in Display → Settings with a 3-way Automatic screen rotation: Disabled / Enabled / Tablet mode only combobox — the UI @mtwebster suggested in #10697.
The control sits over two GSettings: the existing
orientation-lockand the newdisable-rotation-in-laptop-mode(cinnamon-settings-daemon#463). The actual tablet-mode gating is in Muffin: linuxmint/muffin#832. Supersedes the GUI from #10708.Requires #463 (the schema key) to be installed. Happy to take feedback on the wording/layout — or to keep a plain toggle instead if you'd rather.