feat(ui): render per-element Template attributes - #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jaws.InitialHTMLAttrHandlerui.Templatevalue-comparable by consuming attributes during initial render instead of retaining them in the Template or Element stateBehavior change
Existing Template Dots that already implement
jaws.InitialHTMLAttrHandlernow contribute attributes to the generated wrapper during initial render. This includesui.Object; applications using such a Dot may therefore emit wrapper attributes where none were emitted before.Testing
go generate ./...go vet ./...staticcheck ./...golangci-lint rungosec ./...go build ./...JAWS_REQUIRE_NODE=1 go test -race ./...JAWS_REQUIRE_NODE=1 go test ./...The optional local 386 runtime leg could not execute on this aarch64 host (
exec format error); the CIbuild-386job passed on the pushed head.