feat(rust): add exact-argv streaming (#190) - #196
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #190
Bypass the platform shell for executable/argument vectors so Windows callers do not rely on POSIX quoting. Closes #190
konard
marked this pull request as ready for review
August 11, 2026 11:01
Member
Author
Working session summaryImplemented issue #190 and finalized PR #196.
This summary was automatically extracted from the AI working session output. |
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (269.7K + 9.0M cached) input tokens, 35.7K output tokens, $13.312293 cost 🤖 Models used:
📎 Log file uploaded as Gist (3628KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
Member
Author
🎉 Auto-mergedThis pull request has been automatically merged by hive-mind.
Auto-merged by hive-mind with --auto-merge flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamingRunner::from_argvfor spawning an executable with exact OS-native argumentsStreamingRunner::newas the existing shell-command APIRoot cause and reproduction
StreamingRunnerpreviously stored only a command string and always invoked it through/bin/sh -corcmd.exe /c. Callers with an executable plus an argument vector therefore had to flatten arguments into shell syntax; the existing POSIX quoting helper is not valid for Windowscmd.exe.The new integration test invokes the current Rust test binary directly with spaces, shell metacharacters, and quotes in one argument. Before the implementation, it failed to compile because no exact-argv constructor existed. It now verifies successful execution and actual child output.
Verification
cargo fmt --all -- --checkcargo clippy --all-targets --all-featurescargo test --all-featurescargo test --doc --all-featurescargo build --release --all-featurescargo package --allow-dirtygit diff --checkLanguage parity
This is intentionally Rust-only and labeled
parity-exempt. The JavaScript API already supports exact executable/argument invocation throughProcessRunnerexec mode; issue #190 identifies the missing Rust equivalent.Fixes #190