lndclient: add AutoFailHeight to InterceptedHtlc - #287
Open
calvinrzachman wants to merge 1 commit into
Open
Conversation
lnd sends, on every htlc interception, the block height at which it will auto-fail the held htlc to keep the channel from force-closing. The conversion into InterceptedHtlc dropped this field, so callers could not see it and had to reason against IncomingExpiryHeight instead. That is the wrong deadline: the auto-fail height is earlier by lnd's FinalCltvRejectDelta, so a hold-and-forward consumer believes it has more runway than it does.
calvinrzachman
marked this pull request as ready for review
August 18, 2026 02:35
bitromortac
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
lnd sends
auto_fail_heighton every intercepted HTLC, the height at which it will auto-fail the held HTLC to keep the channel from force-closing, but lndclient dropped it. This addsAutoFailHeighttoInterceptedHtlcand passes the field through.
It is the real deadline for work against a held HTLC: earlier than
IncomingExpiryHeightbyFinalCltvRejectDelta, so callers reasoning againstIncomingExpiryHeightthink they have more runway than they do.Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.