Correct the RustyNES core license (MIT/Apache -> GPL-3.0-or-later) - #1180
Open
doublegate wants to merge 1 commit into
Open
Correct the RustyNES core license (MIT/Apache -> GPL-3.0-or-later)#1180doublegate wants to merge 1 commit into
doublegate wants to merge 1 commit into
Conversation
RustyNES relicensed in its v2.2.9 release (2026-08-04). This page predates that change and still lists the old terms.
There was a problem hiding this comment.
Pull request overview
Updates the RustyNES library documentation to reflect the core’s relicensing, keeping the docs aligned with current upstream licensing.
Changes:
- Update RustyNES core license in the Author/License section from
MIT OR Apache-2.0toGPL-3.0-or-later.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RustyNES relicensed from MIT/Apache-2.0 to GPL-3.0-or-later in its v2.2.9 release (2026-08-04). This page predates that change and still lists the old terms.
Single-line change to the Author/License section:
The matching
dist/infocorrection is libretro-super#2069.SPDX form used here deliberately. This page reads as prose, and the neighbouring library pages use full license names rather than the short
.infotokens, soGPL-3.0-or-laterfits the context. The info file uses libretro's own dialect (GPLv3+) for the same license.I checked the rest of the page against the current core rather than only fixing the line I came for, and nothing else needs changing:
.nes,.fds) match the core'sretro_get_system_infodeclaration.disksys.romBIOS entry (md5ca30b50f880eb660a320674ed365ef7a) are unchanged and correct.Restart ✔is newly true rather than newly documented —retro_resetwas unimplemented and inherited the library's no-op default until v2.3.5, so the button did nothing before then.Core Options ✕remains correct; core options are still unexposed.