Conversation
skr4n
force-pushed
the
read-cd
branch
3 times, most recently
from
July 28, 2026 09:11
c16fd18 to
a4e2363
Compare
rocky
reviewed
Jul 28, 2026
Comment on lines
+182
to
+195
| /// Sub-Channel information to include. | ||
| #[repr(u8)] | ||
| #[derive(Clone, Copy, Debug, Default, Eq, Hash, Ord, PartialEq, PartialOrd)] | ||
| pub enum SubchannelOption { | ||
| /// RAW P-W sub-channel data (96 bytes) | ||
| RawPw = 0b001, | ||
|
|
||
| /// Formatted Q sub-channel data (16 bytes). | ||
| #[default] | ||
| Q = 0b010, | ||
|
|
||
| /// Corrected and de-interleaved R-W sub-channel data (96 bytes). | ||
| Rw = 0b100, | ||
| } |
Contributor
There was a problem hiding this comment.
If this corresponds to
of https://www.13thmonkey.org/documentation/SCSI/x3_304_1997.pdf I am seeing other fields mentioned, like 000b (no sub-channel data - which is mandatory to support).
If these are the only options supported right now, we should indicate that there are others and where one can find information on the other unsupported options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A direct interface to the MMC command, with all options provided.
It allows for extracting data from various parts of the disc, including sub-channel data and error correction information.