Add routines based on MMC INQUIRY - #17
Open
skr4n wants to merge 4 commits into
Open
Conversation
skr4n
changed the title
INQUIRY and TEST UNIT READYINQUIRY and TEST UNIT READY
skr4n
force-pushed
the
inquiry-and-test-ready
branch
3 times, most recently
from
July 28, 2026 09:11
580dbb5 to
285b701
Compare
skr4n
changed the title
INQUIRY and TEST UNIT READYINQUIRY
skr4n
force-pushed
the
inquiry-and-test-ready
branch
from
July 28, 2026 15:07
285b701 to
ae1b7a2
Compare
rocky
reviewed
Jul 28, 2026
| const PRODUCT_ID_END_POS: usize = 31; | ||
| const REVISION_START_POS: usize = 32; | ||
| const REVISION_END_POS: usize = 35; | ||
| } |
Contributor
There was a problem hiding this comment.
What, if any, are the implications of having this appear after the return statement as opposed to at the start of the function or before the return?
To verify that this information is correct. I went to a MMC-5 PDF that then directed me to a SPC3 PDF https://www.t10.org/ftp/t10/document.08/08-309r1.pdf where I found
What can we do to make it more transparent and easier for someone to be able to verify this kind of information?
rocky
reviewed
Jul 28, 2026
| } | ||
| } | ||
|
|
||
| /// could not get hardware identifers |
Contributor
There was a problem hiding this comment.
Suggested change
| /// could not get hardware identifers | |
| /// could not get hardware identifiers |
rocky
reviewed
Jul 28, 2026
|
|
||
| /// could not get hardware identifers | ||
| #[derive(Debug, Display, Error)] | ||
| pub struct GetHardwareIdentifersError { |
Contributor
There was a problem hiding this comment.
Suggested change
| pub struct GetHardwareIdentifersError { | |
| pub struct GetHardwareIdentifiersError { |
rocky
reviewed
Jul 28, 2026
| /// Routines based on MMC `INQUIRY`. | ||
| impl Mmc { | ||
| /// Get the hardware identifiers (Product, Vendor and Revision). | ||
| pub fn hardware_identifiers(&self) -> Result<HardwareIdentifiers, GetHardwareIdentifersError> { |
Contributor
There was a problem hiding this comment.
Suggested change
| pub fn hardware_identifiers(&self) -> Result<HardwareIdentifiers, GetHardwareIdentifersError> { | |
| pub fn hardware_identifiers(&self) -> Result<HardwareIdentifiers, GetHardwareIdentifiersError> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add routines based on MMC command
INQUIRY:hardware_identifiers(): Returns Vendor, Product and Revision of the device