Add routines based on MMC PREVENT ALLOW MEDIA REMOVAL - #15
Open
skr4n wants to merge 4 commits into
Open
Conversation
skr4n
changed the title
PREVENT ALLOW MEDIA REMOVALPREVENT ALLOW MEDIA REMOVAL and START STOP UNIT
rocky
reviewed
Jul 27, 2026
|
|
||
| return self.run_command(Some(MmcDirection::Write), &mut [], cdb); | ||
|
|
||
| const OPCODE: u8 = 0x1E; |
Contributor
There was a problem hiding this comment.
Same comment as in PR #13. This is a problem with waiting a week or so and then putting in 8 PRs rather than putting in the PR as work is done, even as a draft.
If something is going in the wrong direction, continuing that direction 7 more times makes things worse from the reviewer's standpoint.
Collaborator
Author
There was a problem hiding this comment.
Ok, I've made the change.
This is a problem with waiting a week or so and then putting in 8 PRs rather than putting in the PR as work is done, even as a draft.
I was waiting on you to merge existing PRs (as newer ones are dependent on earlier ones) but since yesterday you'd asked to push all the code, I've done so.
skr4n
force-pushed
the
prevent-allow-media-removal
branch
2 times, most recently
from
July 28, 2026 04:25
a3747b2 to
d004cca
Compare
There are two major types of drivers in Cdio. - OS - Images Thus, rather than have a generic `new()` method with multiple (unused) initialization options, have two methods `with_device()` and `with_image()`. This commit introduces `with_device()`.
skr4n
force-pushed
the
prevent-allow-media-removal
branch
from
July 28, 2026 15:02
680825b to
508ab6f
Compare
skr4n
changed the title
PREVENT ALLOW MEDIA REMOVAL and START STOP UNITPREVENT ALLOW MEDIA REMOVAL
skr4n
changed the title
PREVENT ALLOW MEDIA REMOVALPREVENT ALLOW MEDIA REMOVAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add routines based on MMC command
PREVENT ALLOW MEDIA REMOVAL:allow_media_removal()prevent_media_removal()