replaced naive trapdoor interact with baritone pathing and interaction to keep rotations correct when interacting.#17
Open
CrisisSheep wants to merge 5 commits into
Open
Conversation
fireClick previously sent the interact packet and unconditionally declared the pull successful, with no rotation toward the trapdoor and no check that the click actually landed - it could silently miss and still whisper 'Pulled'. Splits into two paths depending on whether the owner was already online when positioning finished: - Already online: uses Baritone's rightClickBlock, which reaches the block correctly regardless of intervening blocks, rotates and clicks atomically at a priority that beats Spook, and verifies the interact resolved against the right block via ClickResult before declaring success. Bounded by a 3s confirmation timeout since Baritone's own retry limit only covers path calculation failures, not stuck interact attempts. On a confirmed miss or timeout, reports failure and tells the player to re-request rather than retrying automatically. - Owner comes online after waiting: kept as the raw, zero-latency packet send (unverified) since routing this through rightClickBlock's InputManager round-trip would cost at least one extra tick right when responsiveness matters most. Correctness instead comes from continuously re-facing the trapdoor every tick for the whole wait, so the bot is already aimed correctly the instant the owner logs in instead of wherever Spook or idle behavior last left it pointed.
Contributor
Author
|
fixed race condition causing pearl chambers to be mis-counted for whispers. also increased antispam length to stop antispam catching it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the bot now uses baritone pathing and interaction which keeps the look rotations correct so that there are less false pulls that are reported as working.
still use the old interact system for offline pulling to keep delay from login to pull as low as possible, instead we just update the look rotation every tick to keep the bot looking at the trapdoor until the owner logs on.
fixed the bot saying that it has pulled successfully when it hadnt (only for online pulls), now it will notify the player the pull failed if its 3s of reattempts also fail.