Skip to content

feat: Update zksolc version to "1.13.17" #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ColoCarletti wants to merge 2 commits into
base: yul-console-log-vm-fixes
Choose a base branch
from
Open

feat: Update zksolc version to "1.13.17" #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a36c165
update zksolc version
ColoCarletti Nov 27, 2023
75fa7bb
change console.yul log address
ColoCarletti Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion etc/system-contracts/contracts/precompiles/Console.yul
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ object "Console" {
// CONSOLE.LOG Caller
// It prints 'val' in the node console and it works using the 'mem'+0x40 memory sector
function console_log(mem, val) -> {
let log_address := 0x000000000000000000636F6e736F6c652e6c6f67
// With zksolc 1.13.17 version, log_address must be 16 bit long
// let log_address := 0x000000000000000000636F6e736F6c652e6c6f67
let log_address := 0x000000000000000000000000000000000000f000
// load the free memory pointer
let freeMemPointer := mload(mem)
// store the function selector of log(uint256) in memory
Expand Down
2 changes: 1 addition & 1 deletion etc/system-contracts/hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const systemConfig = require('./SystemConfig.json');

export default {
zksolc: {
version: '1.3.14',
version: '1.3.17',
compilerSource: 'binary',
settings: {
isSystem: true
Expand Down
2 changes: 1 addition & 1 deletion etc/system-contracts/scripts/compile-yul.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { exec as _exec, spawn as _spawn } from 'child_process';

import { getZksolcUrl, saltFromUrl } from '@matterlabs/hardhat-zksync-solc';

const COMPILER_VERSION = '1.3.14';
const COMPILER_VERSION = '1.3.17';
const IS_COMPILER_PRE_RELEASE = false;

import path from "path";
Expand Down
2 changes: 1 addition & 1 deletion etc/test-contracts/hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const systemConfig = require('./SystemConfig.json');

export default {
zksolc: {
version: '1.3.14',
version: '1.3.17',
compilerSource: 'binary',
settings: {
isSystem: true
Expand Down