show control relationship type with icon and tooltip in compliance posture view - #888
Open
refoo0 wants to merge 1 commit into
Open
show control relationship type with icon and tooltip in compliance posture view#888refoo0 wants to merge 1 commit into
refoo0 wants to merge 1 commit into
Conversation
…sture view Signed-off-by: rafi <refaei.shikho@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds UI support in the compliance posture detail view to display the relationship between mapped controls (e.g., equivalent/intersects/subset/superset) using an icon with a tooltip description, backed by an updated API DTO type.
Changes:
- Extended
CompliancePostureWithControlDTO.mappedControls[]to include arelationshipdiscriminator. - Updated
CompliancePostureDetailViewto render mapped controls with relationship icons and tooltip descriptions. - Refactored mapped-control grouping to carry relationship metadata through to the UI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/types/api/api.ts | Adds mappedControls[].relationship to the compliance posture DTO type. |
| src/components/compliance-posturers/CompliancePostureDetailView.tsx | Renders mapped controls with relationship icons + tooltips and updates grouping logic accordingly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+177
to
+180
| <Badge | ||
| variant="secondary" | ||
| className="mr-2 mb-2 flex cursor-default items-center gap-1" | ||
| > |
Comment on lines
+135
to
+151
| function RelationshipIcon({ | ||
| relationship, | ||
| }: { | ||
| relationship: ControlRelationship; | ||
| }) { | ||
| const className = "h-3 w-3"; | ||
| switch (relationship) { | ||
| case "equivalent-to": | ||
| return <EqualIcon className={className} />; | ||
| case "intersects-with": | ||
| return <GitMergeIcon className={className} />; | ||
| case "subset-of": | ||
| return <ArrowDownToLineIcon className={className} />; | ||
| case "superset-of": | ||
| return <ArrowUpFromLineIcon className={className} />; | ||
| } | ||
| } |
Comment on lines
+121
to
+125
| type ControlRelationship = | ||
| | "equivalent-to" | ||
| | "intersects-with" | ||
| | "subset-of" | ||
| | "superset-of"; |
Comment on lines
1318
to
+1322
| ( | ||
| vuln.mappedControls as { | ||
| relatedFramework: string; | ||
| relatedControlId: string; | ||
| relationship: ControlRelationship; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.