Skip to content

fix: preserve new-tab navigation for dependency risks - #879

Open
fzlzjerry wants to merge 2 commits into
l3montree-dev:mainfrom
fzlzjerry:fix/2801-open-dependency-risk-tabs
Open

fix: preserve new-tab navigation for dependency risks#879
fzlzjerry wants to merge 2 commits into
l3montree-dev:mainfrom
fzlzjerry:fix/2801-open-dependency-risk-tabs

Conversation

@fzlzjerry

@fzlzjerry fzlzjerry commented Aug 9, 2026

Copy link
Copy Markdown

Summary

  • render directly navigable CVE identifiers as real links in the dependency risk table
  • let existing path links handle browser navigation without a competing row-level router.push
  • preserve Ctrl/Cmd-click, middle-click, and context-menu behavior for opening multiple risk details

Fixes l3montree-dev/devguard#2801.

Validation

The source change was validated before the dedicated regression suite was removed at the maintainer's request:

  • npm test -- --runInBand (8 suites, 33 tests)
  • npx tsc --noEmit --pretty false
  • npx eslint src/components/risk-handling/RiskHandlingRow.tsx
  • npx prettier --check src/components/risk-handling/RiskHandlingRow.tsx
  • git diff --check

The final PR diff is limited to RiskHandlingRow.tsx.

Signed-off-by: Morax <james20081204@gmail.com>
@timbastin

Copy link
Copy Markdown
Member

Hi @fzlzjerry thanks a lot for your contribution. I already peeked at the changes of this PR even though it's currently in draft. I think the fix is rather straightforward and does not need this excessive testing. If you delete the tests, I think we can merge this ASAP.

Signed-off-by: Morax <james20081204@gmail.com>
@fzlzjerry

Copy link
Copy Markdown
Author

Thanks for the quick review. I removed the dedicated
RiskHandlingRow.test.tsx suite as requested, so the final diff is now limited
to the navigation change in RiskHandlingRow.tsx. The update is in
7b7bd3c.

@fzlzjerry
fzlzjerry marked this pull request as ready for review August 11, 2026 08:57
Copilot AI lite review requested due to automatic review settings August 11, 2026 08:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to open new Tab when working on dependency risks

3 participants