fix: preserve new-tab navigation for dependency risks - #879
Open
fzlzjerry wants to merge 2 commits into
Open
Conversation
Signed-off-by: Morax <james20081204@gmail.com>
Member
|
Hi @fzlzjerry thanks a lot for your contribution. I already peeked at the changes of this PR even though it's currently in draft. I think the fix is rather straightforward and does not need this excessive testing. If you delete the tests, I think we can merge this ASAP. |
Signed-off-by: Morax <james20081204@gmail.com>
Author
|
Thanks for the quick review. I removed the dedicated |
fzlzjerry
marked this pull request as ready for review
August 11, 2026 08:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
router.pushFixes l3montree-dev/devguard#2801.
Validation
The source change was validated before the dedicated regression suite was removed at the maintainer's request:
npm test -- --runInBand(8 suites, 33 tests)npx tsc --noEmit --pretty falsenpx eslint src/components/risk-handling/RiskHandlingRow.tsxnpx prettier --check src/components/risk-handling/RiskHandlingRow.tsxgit diff --checkThe final PR diff is limited to
RiskHandlingRow.tsx.