Conversation
The pixi install shell script downloads the latest version of pixi. Setting the `PIXI_VERSION` env variable in the pixiw scripts allows us to pin the version of Pixi. Also remove two pixiw files that must have been committed before we started gitignoring them.
Contributor
|
Thanks @holodorum! I have a couple of questions here that are easier realtime鈥攍et's have a quick look at this together before we merge. |
Pinning PIXI_VERSION only affects a fresh install, and the wrapper was only generated when `pixiw` was missing, so anyone with a pixiw already on disk kept an unpinned wrapper and an off-pin Pixi forever. The generated wrappers now compare `pixi --version` against the pin and reinstall when it differs, and PixiExecTask regenerates the wrapper on every run so wrapper changes propagate. Regenerating unconditionally exposed a latent clash: generateWrapper registered a task under a fixed name, which failed for the second Pixi task in a project, so the name is now derived from the task. pixiw.bat stays untested since it needs cmd.exe.
Ran `pixi lock` to re-solve the four remaining v6 lock files using their locked content, bringing them in line with lib-rust (already v7) and the pixi version developers now run. No dependency changes.
Contributor
|
Great additions, thanks @holodorum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pixi install shell script downloads the latest version of pixi. Setting the
PIXI_VERSIONenv variable in our pixi wrapper scripts allows us to pin the version of Pixi.Also remove two pixi wrapper files that must have been committed before we started gitignoring them.