fix: convert artist credit rows to flexboxes to handle rtl correctly#233
fix: convert artist credit rows to flexboxes to handle rtl correctly#233arsinclair wants to merge 1 commit into
Conversation
kellnerd
left a comment
There was a problem hiding this comment.
Very interesting, I am not even sure if the previous behavior is some kind of bug in the rendering engine... thank you for reporting @YoGo9!
You are right @arsinclair, in order to keep the entity name as link without this weird glitch, flex-boxes seem to be the proper solution as far as I can see.
However, the list items of the alternative values can't be flex-boxes themselves, with this change they lose their bullet points. We probably need an additional container to achieve the desired outcome.
Also, the same issue potentially affects all entity links, so the CSS changes should target those and not just artist credits.
|
Awesome, then I hope maybe @YoGo9 or @kellnerd can take it forward from here? My PR was just a scratchpad example to show what I mean, neither did I test it well nor have I verified this issue in other areas of the app :) I'd be glad to complete the implementation, but unfortunately I'm very short on time right now. |
This is to fix the issue in #229
Test link: https://harmony.pulsewidth.org.uk/release?url=https%3A%2F%2Ftidal.com%2Falbum%2F529736650>in=®ion=GB%2CUS%2CDE%2CJP&musicbrainz=&deezer=&itunes=&spotify=&tidal=&qobuz=&beatport=
Before the change:

After the change:
