feat: productionization stack + host path/auth gates - #1
Open
jtmilan wants to merge 3 commits into
Open
Conversation
Lands the 2026-08-06 productionization work (PTY host, tests, fail-closed entitlements, PGlite dataDir, settings) plus a second-pass PR gate: - Register host-owned workspace roots; reject spawn/destroy outside them - Collapse `..` before path prefix checks; refuse rm -rf of the repo root - Persona no longer mints an API bearer; unsigned cache falls back to free - Ignore .envrc, Tauri target, and clipboard dumps - Unskip the fail-closed canUse pin Rotate the leaked GROK preview client secret in the broker — it remains in git history on main.
Adversarial pass after rebasing onto main's desktop-dist/preflight: - Do not default Authorization to Bearer operator - Demo fleet worktrees are in-repo children, not /tmp - Drop client HMAC from .env.example and protocol docs - Allow packaged webview to reach local ade-api in CSP
Owner
Author
|
Rebased onto Conflict resolution: kept main's preflight + Reviewer blockers fixed in the follow-up commit:
Still follow-up (not blocking this rebase): real Claude Gates after rebase: |
jtmilan
force-pushed
the
feat/productionization-host-gates
branch
from
August 12, 2026 20:54
91be02b to
a59675c
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Returning a fresh object from getServerSnapshot trips React 19's infinite-loop guard on every SSR/hydration read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ships the 2026-08-06 productionization work that was sitting uncommitted on
main, then closes the blockers a 5-lane polyglot-broker review found before this could go public.Repo path reviewed:
~/Personal/agent-commandcenter(the Grok workspace folder is not this git tree).Review lanes (
/polyglot-broker)rusttypescriptarchitecturesecuritytestingcanUseGated/skipped panes: none (no
db-migration/ coordinator / bash harness).What landed
..collapse, refuserm -rfof the workspace root, harness basename allowlist, unique job ids,RunEvent::Exitkill-allTerminalView(SSR-safe), settings store, wizard Browse toasts, demo fleet confirm +killAllJobs+ MCP fields.envrc,src-tauri/target/, clipboard dumps not committedGates run
npm run typechecknpm run lintnpm testcd src-tauri && cargo test --libnpm run build:webdb:migrate)Still follow-up (not this PR)
GROK_AUTH_CLIENT_SECRET/ preview client in the broker — value is still in git history onmain.mcp.json)npx playwright install chromiumlocally/meDo not merge if
You have not rotated the broker preview secret. The constant is gone from this tree; history is not.