Docstrings, type annotations, code formatting with ruff#4
Open
ntamas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the codebase by the following:
uv run ty checkpasses cleanly onntp.pyruffI did this primarily for inclusion of the library in a larger project of mine where we need to follow stricter conventions (especially regarding type correctness), but I thought this might be useful for the upstream project as well.
No changes in behaviour were added yet.
Note that due to the usage of type annotations and the current minimum Python version of the project being at 3.5 this is a breaking change.
setup.pyshould probably be migrated topyproject.tomlas well in the future; let me know if you would like me to file a PR for that.