Adding more fields to the all nodes table#917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds quick node posture, health, and tag visibility to the all-nodes table and single-node detail view.
Changes
Node API Projection
NodeViewwith:posture.risk_leveltagshealth.statushealth.reasonhealth.signalsofflinewhen the node is inactiveat_riskfor high/critical posture riskattentionfor medium or unknown posturehealthyfor active nodes with low/no riskPosture Summary
All Nodes Table
HealthandTagscolumns.Activityfocused on last seen and bytes received.low,medium, orhigh.Single Node View
Healthsection in the Details tab.Frontend Shared Components
Tests
Validation
npm test -- NodesTablePage.test.tsxnpm test -- NodeDetailPage.test.tsxnpm run checkGOCACHE=/tmp/osctrl-gocache go test ./pkg/tags ./pkg/types ./pkg/posture ./cmd/api/handlersGOCACHE=/tmp/osctrl-gocache go test ./cmd/api/handlersgit diff --check