Skip to content

fix: stop treating OIDC username as a secret #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amarkdotdev wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −4
Open

fix: stop treating OIDC username as a secret #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/oidc-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ class OidcUtils {
}
static setOidcStepOutputs(username, accessToken) {
core.setSecret(accessToken);
core.setSecret(username);
core.setOutput('oidc-token', accessToken);
core.setOutput('oidc-user', username);
}
Expand Down
1 change: 0 additions & 1 deletion src/oidc-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ export class OidcUtils {

public static setOidcStepOutputs(username: string, accessToken: string): void {
core.setSecret(accessToken);
core.setSecret(username);
core.setOutput('oidc-token', accessToken);
core.setOutput('oidc-user', username);
}
Expand Down
4 changes: 2 additions & 2 deletions test/oidc-utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ describe('OidcUtils', (): void => {
});

describe('setOidcStepOutputs', (): void => {
it('should export user/token as step output and secret', (): void => {
it('should export user/token as step output and mark token as secret', (): void => {
OidcUtils.setOidcStepOutputs('foo', 'bar');
expect(core.setSecret).toHaveBeenCalledWith('bar');
expect(core.setSecret).toHaveBeenCalledWith('foo');
expect(core.setSecret).not.toHaveBeenCalledWith('foo');
expect(core.setOutput).toHaveBeenCalledWith('oidc-token', 'bar');
expect(core.setOutput).toHaveBeenCalledWith('oidc-user', 'foo');
});
Expand Down
Loading