APP-6261 - Add-aql-resource-type-for-version-create - #98
Merged
asafgabai merged 1 commit intoAug 17, 2026
Merged
Conversation
yurinovo18
force-pushed
the
APP-6261-add-aql-resource-type-for-version-create
branch
from
August 16, 2026 07:23
a4283d0 to
24e482e
Compare
yurinovo18
force-pushed
the
APP-6261-add-aql-resource-type-for-version-create
branch
from
August 16, 2026 08:07
24e482e to
2c2e646
Compare
asafgabai
added
the
safe to test
github-actions
Bot
removed
the
safe to test
Contributor
asafgabai
reviewed
Aug 16, 2026
| return targetPath | ||
| } | ||
|
|
||
| // SplitRepoAndPath splits an Artifactory path of the form "<repo>/<path>" into its two parts. |
Collaborator
There was a problem hiding this comment.
Consider removing this comment
| defer utils.DeleteApplication(t, appKey) | ||
|
|
||
| artifactPath := utils.GetTestArtifact(t) | ||
| repoKey, fileName := utils.SplitRepoAndPath(t, artifactPath) |
Collaborator
There was a problem hiding this comment.
Instead of creating a function that splits a string you built in another util function, consider returning the string parts as GetTestArtifact's return values.
yurinovo18
force-pushed
the
APP-6261-add-aql-resource-type-for-version-create
branch
from
August 17, 2026 09:29
2c2e646 to
81f34a7
Compare
asafgabai
added
the
safe to test
github-actions
Bot
removed
the
safe to test
asafgabai
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainbranch.go vet ./....go fmt ./....