fix: remove token requirement from /v3/stats - #581
Merged
Conversation
The node_stats endpoint requires TokenOnly but never uses the token, just calls ch.get_node_stats() which reads public ClickHouse counts. Marketing-ui sends empty body (pre-signup, no auth) which caused 422.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
POST /v3/statsreturns 422:Field requiredfortokenwhen called without a token.Root Cause
The
node_statsendpoint requiredTokenOnly(a JWT token) but never used it — it just callsch.get_node_stats()which reads public ClickHouse counts. Marketing-ui sends empty body (pre-signup, no auth).Fix
Removed the
TokenOnlybody parameter. The endpoint returns public stats (user count, doc count, group count, approved apps, storage) — no sensitive data requires auth.