Feature set 135. - #62
Merged
Merged
Conversation
Correct the edge secret setup steps. The instructions assumed a global wrangler and named only the secret. Both were wrong: npx fetches wrangler on demand, and the secret does nothing unless the worker.js change that injects the header is deployed alongside it. Adds the dashboard route for when there is no terminal. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only.
The setup steps in
cloudflare/RATE-LIMITING.mdhad two problems, both found by trying to followthem:
wrangler.npx wranglerneeds no install, and Node isalready present.
withEdgeSecretinworker.js, so that deploy has to happen too. Setting a secret against theold deployment would have looked like completing the setup while changing nothing, which is the
same silent-failure shape the rest of that document warns about.
Also adds the Cloudflare dashboard route for both halves, for when there's no terminal to hand.
Note
release.ymlignores**.md, so this cuts no tag.🤖 Generated with Claude Code