Feature set 131. - #58
Merged
Merged
Conversation
Promote generated artwork automatically. Generation wrote to GeneratedImageUrl and stopped, leaving a separate promote run to put it live. In practice that meant art that had been paid for sat unserved until someone remembered the second step -- the last batch finished with 309 images generated and none of them visible. generate now promotes what it produced. The review-before-live step was never what stood between a bad image and the catalogue: unpromote is, and it still restores the original and deletes the replacement. Both columns are kept for exactly that reason. promote remains available on its own, which is the only way to pick up art from a run that predates this change. Note that promote acts on every row holding generated art, not just the current batch -- documented on PromoteAsync, since with it now firing automatically that scope is easier to trip over. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote generated artwork automatically
Generation wrote to
GeneratedImageUrland stopped there, leaving a separatepromoterun to put it live. The last batch finished with 309 images generated and none of them visible — art that had been paid for, sitting unserved until someone remembered the second step.generatenow promotes what it produced.The staging step was justified as a review gate, but it was never the thing standing between a bad image and the catalogue —
unpromoteis, and it still restores the original and deletes the replacement. Both columns are kept for exactly that reason, so the undo path is unchanged.promoteremains available on its own. That's now the only way to pick up art from a run predating this change.Note
PromoteAsyncacts on every row holding generated art, not just the batch that just ran. That was already true, but it was easy to overlook when promote had to be asked for by name; now that it fires automatically, anything generated and deliberately left unpromoted earlier will go live on the next generate. Documented on the method.Also refreshed the comments that described the old staging behaviour —
ImageGenerator's class remarks,Monster.GeneratedImageUrl, and the workflow'sstagesinput description.🤖 Generated with Claude Code