Skip to content

fix(ci): drop --if-present from the lerna build step so the publish can actually run #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
izzywdev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ci): drop --if-present from the lerna build step so the publish can actually run #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/packages-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,17 @@ jobs:
# proves nothing about that, so assert it before shipping anything.
run: node --test scripts/__tests__/publish-packages.test.mjs

- name: Build packages (topological, if a build script exists)
run: npx lerna run build --if-present
- name: Build packages (topological)
# NOT `--if-present`: lerna 10 removed it and errors with
# "Unknown arguments: if-present, ifPresent". That flag was inherited
# from this workflow's original form and had never executed — the job was
# gated on an owner that does not exist, so every run for the life of the
# file was a skip. Fixing the guard is what first ran this line.
#
# The flag is also unnecessary: `lerna run <script>` already skips
# packages that do not define it. Verified locally — 24 projects built,
# exit 0.
run: npx lerna run build

- name: Resolve what would publish
run: node scripts/publish-packages.mjs --dry-run
Expand Down
Loading