add livecodes.io plugin#684
Open
hatemhosny wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Category: N/A (external contribution — new domain plugin)
Task: No task — adds a domain plugin for LiveCodes, a registered oEmbed provider (oembed.com registry entry)
Demo and staging
Demo link: https://iframely.com/try?url=https%3A%2F%2Flivecodes.io%2F%3Ftemplate%3Dreact
Screenshot:
/debug?uri=https%3A%2F%2Flivecodes.io%2F%3Ftemplate%3Dreact:
About the changes
What has changed
Please describe what the code is doing (in this repo):
plugins/domains/livecodes.io.js, a domain plugin for LiveCodes code playgrounds.richtype) with per-URL discovery tags athttps://livecodes.io/oembed. The domain is already in the central whitelist (oembed.rich: allow, horizontal, reader, resizable), so generic oEmbed works today — this plugin adds embed options on top of it.livecodes.io/and versioned/permanent-URL subdomains (e.g.v49.livecodes.io/) with an optionalindex.html, query string and hash, while deliberately not matching other paths such as/docs/*or/blog/*(regular content pages, no embeds).getLinktakes the iframe extracted from the oEmbedhtml(via theoembed-iframemixin) and exposes three user-facing options:height(400);loading=click, LiveCodes' native deferred-loading mode for embeds;light/darkvia thethemequery param, withauto(param removed) as default, read through the standardplayers.themerequest option.oembed-author(LiveCodes responses have no author fields) anddescription(not provided).Related PRs in other repos
Checklist
Review
Please note any risks, caveats, migration steps, release notices or additional tasks.
Testing done locally (self-hosted instance from this branch):
GET /iframely?url=https://livecodes.io/?template=reactreturns the app link, correct href, height, and the three options; theme/height/click_to_load option changes round-trip into the iframe URL as expected.https://livecodes.io/docs/features/embeds) correctly fall through to generics.theme=dark,theme=lightandloading=clickverified against the live embed URLs.Notes for maintainers: