Preserve Harbor role failures reported by return_code - #329
Merged
Conversation
Worker gpt-5.6-luna (reasoning=high), packaged by the orchestrator (G1-A/C). spec_digest: 0832e6cf0b69dbc44cd120eb38084c44a44d415a302573aa1c21a4c0d36b4818 base_sha: bf7d122 attempt: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ExecResult.return_codefailures in the existing role-result normalization seam.Why
Harbor reports in-container role failures through
return_code, while Relay read onlyreturncodeandexit_code. A nonzero worker exit could therefore be interpreted as success and continue into review.Evidence
ab3ee8acbd01a51d358e80d9150226b7839b5918.ciand was merged through./scripts/dispatch merge.4085954648b191ccc10c296ec4fc58d5c9d35d4353e26eb36147cc5d5c7afc24, identical to the reviewed worker diff.Owner action
Merge after this PR's own
ciis green. The orchestrator will not merge it.