Skip to content

docs: Update plugin documentation - #599

Open
OS-pedrogustavobilro wants to merge 2 commits into
mainfrom
plugin-doc-updates
Open

docs: Update plugin documentation#599
OS-pedrogustavobilro wants to merge 2 commits into
mainfrom
plugin-doc-updates

Conversation

@OS-pedrogustavobilro

@OS-pedrogustavobilro OS-pedrogustavobilro commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

v8 and v9 updates are the same, with one exception: File viewer only has v8 updates v9 was already updated from a previous PR.

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
capacitor-docs Ready Ready Preview Aug 21, 2026 12:11pm

Request Review

@jcesarmobile

Copy link
Copy Markdown
Member

for local-notifications is using the main branch, while we have a few next releases, but there is no next branch on https://github.com/ionic-team/capacitor-local-notifications, so the current next release doesn't include the error codes, so not sure what we want to do about that.

@OS-pedrogustavobilro

OS-pedrogustavobilro commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

We'll have to update that repo to cap 9 (and a few others) and generate a next version (possibly the JIRA items don't exist yet).

I personally don't see an issue with merging this PR as-is, because while the current alpha version doesn't have error codes, we are still in alpha.

Or was your concern about something else?

@jcesarmobile

Copy link
Copy Markdown
Member

my concern was about you only mentioning file-viewer as "not having next version", and not mentioning anything about local-notifications, which has a next version but it's not being used.

because while the current alpha version doesn't have error codes, we are still in alpha.

I don't think you understood me, or this commend is confusing me.
Both local-notification files are using the main readme, which has the error codes, the 9.x docs are not using the next version readme, which doesn't have the error codes yet (as the plugin was moved to a new repository with no next branch)

We could to the same and make file-viewer use the main tag for now too, that's what I find confusing, doing one thing with one plugin and a different thing with the other.

@OS-pedrogustavobilro

Copy link
Copy Markdown
Contributor Author

Ahh okay I get what you mean now. Sorry I had not understood before.

Well, I said in the PR to wait for new next release of File Viewer, but I didn't technically need to (maybe it was just my misunderstanding), so I went ahead and released it now. Funny thing is, the reason why the docs for next didn't update for file viewer is not because it was missing a release, but rather because the docs were already updated from a previous release and PR 🤦 😆 So it was just confusion on my part, all's well for file viewer.

As for local-notifications, since we can't point to the next branch of capacitor-plugins because local-notifications was removed from there, the alternative would be to point to the next branch of capacitor-local-notifications (which exists, but it's not yet Cap 9 compatible) and remove the latest tag - So the next doc would have content from the most recent next version (which was from capacitor-plugins, but the edit url points to what would be the correct URL to edit the file (even though that file will have more than what existed for capacitor-plugins). I don't know if that's better than what we have now, and in any case both are just temporary until that repo is updated for Cap 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants